Make buffer size configurable at compile time and set it to 8192#74
Closed
jcorporation wants to merge 1 commit intoMusicPlayerDaemon:masterfrom
Closed
Make buffer size configurable at compile time and set it to 8192#74jcorporation wants to merge 1 commit intoMusicPlayerDaemon:masterfrom
jcorporation wants to merge 1 commit intoMusicPlayerDaemon:masterfrom
Conversation
jcorporation
force-pushed
the
buffer_size
branch
from
a0ba445 to
a2c9ed4
Compare
Member
|
I don't think a compile-time option is a good idea. Rarely ever will people do their own libmpdclient build, and adding that compile-time knob will make us believe the problem is fixed, when in practice it's not for most people. We need a fallback to dymamic allocation like #53 (which was not yet merged because the code was too complicated and fragile.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit: I notified meanwhile the default mpd output buffer is 8 MiB not 8 kiB
The libmpdclient buffer is the max length of a output line and this is not limited on server side?
But eventually this patch is even so useful?
Or I struggling with all of this?